Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero buttons responsive bug fixed and repo-card also #217

Merged

Conversation

SharizHussain
Copy link
Contributor

Your recent button issue fixed
and previous responsive issue also solved

please label me approved and merge after check it

Copy link

vercel bot commented Oct 1, 2024

@SharizHussain is attempting to deploy a commit to the Max Programming's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hacktoberfest-projects ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:05am

@max-programming
Copy link
Owner

Looks good but why do the buttons stick together?

image

@SharizHussain
Copy link
Contributor Author

SharizHussain commented Oct 1, 2024 via email

@max-programming
Copy link
Owner

max-programming commented Oct 1, 2024

That looks good! Thanks

Can you please fix the problems I mentioned in the review above?

@SharizHussain
Copy link
Contributor Author

Sure now I have added the package-lock.json file in gitignore and navbar's sign in button was sticky to hacktoberfest is fixed.

WhatsApp Image 2024-10-02 at 01 35 51

Screenshot from 2024-10-02 01-32-39

@max-programming max-programming merged commit 1dbbcdd into max-programming:main Oct 2, 2024
5 checks passed
@max-programming
Copy link
Owner

@all-contributors add @SharizHussain for bug, code

Copy link
Contributor

@max-programming

I've put up a pull request to add @SharizHussain! 🎉

@SharizHussain
Copy link
Contributor Author

SharizHussain commented Oct 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants