Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the path to adapalint via system.file #1

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

jimhester
Copy link
Contributor

In lintr 2.0.0 the previous path does not find a package, so returns
NULL and causes a failure. Using system.file() fixes the issue.

I am actually somewhat baffled how this was working at all in R CMD check in the old version of lintr, the tests are not run in a parent of the package during R CMD check, so the package would not have previously been found.

In lintr 2.0.0 the previous path does not find a package, so returns
NULL and causes a failure. Using `system.file()` fixes the issue.
@lintr-bot
Copy link

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:78:9: style: Only use double-quotes.

​    `$`('linter')
        ^~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:80:22: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                     ^~~~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:80:54: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                                                     ^~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:113:9: style: Only use double-quotes.

​    `$`('linter')
        ^~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:115:22: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                     ^~~~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:115:54: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                                                     ^~~~~~~

1 similar comment
@lintr-bot
Copy link

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:78:9: style: Only use double-quotes.

​    `$`('linter')
        ^~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:80:22: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                     ^~~~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:80:54: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                                                     ^~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:113:9: style: Only use double-quotes.

​    `$`('linter')
        ^~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:115:22: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                     ^~~~~~~~~~

/home/travis/build/maxconway/adaptalint/adaptalint.Rcheck/adaptalint/extdata/styles.R:115:54: style: Only use double-quotes.

baselinters <- get('settings', envir = asNamespace('lintr'),
                                                     ^~~~~~~

@maxconway maxconway merged commit 9e826f6 into maxconway:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants