avoid heap allocations with session id #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 71.32% 71.37% +0.05%
==========================================
Files 5 5
Lines 279 283 +4
==========================================
+ Hits 199 202 +3
- Misses 80 81 +1 ☔ View full report in Codecov by Sentry. |
Here we've revisited our implementations of `Display` and `FromStr` for `Id` and updated them to leverage the stack via slices. Technically this is a breaking change because we've also updated the `IdError`.
This takes advantage of the recent update to the base64 crate. We've also removed our custom error type in favor of using the base64 error type directly.
maxcountryman
force-pushed
the
session-id-stack-allocation
branch
from
ec337b0
to
f408d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we've revisited our implementations of
DisplayandFromStrforIdand updated them to leverage the stack via slices.Technically this is a breaking change because we've also updated the
IdError.