Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0: TraceablePDO adding query arguments #460

Merged
merged 2 commits into from
Dec 7, 2020
Merged

PHP 8.0: TraceablePDO adding query arguments #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343417e
php 8 fix
n0x073 Dec 1, 2020
9ac6e0d
Update TraceablePDO.php
n0x073 Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/DebugBar/DataCollector/PDO/TraceablePDO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,12 @@ public function prepare($statement, $driver_options = [])
*
* @link http://php.net/manual/en/pdo.query.php
* @param string $statement
* @param int $fetchMode
* @param mixed ...$fetchModeArgs
* @return TraceablePDOStatement|bool PDO::query returns a PDOStatement object, or FALSE on
* failure.
*/
public function query($statement)
public function query($statement, $fetchMode = null, ...$fetchModeArgs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ?int $fetchMode = null?

{
return $this->profileCall('query', $statement, func_get_args());
}
Expand Down