Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable copy, tweak icon #676

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Enable copy, tweak icon #676

merged 1 commit into from
Sep 10, 2024

Conversation

barryvdh
Copy link
Collaborator

@barryvdh barryvdh commented Sep 10, 2024

Instead of the alert, toggle the copy button with a similar icon for 2 seconds, to indicate success.
image

@barryvdh barryvdh merged commit ce4762b into master Sep 10, 2024
16 checks passed
@erikn69
Copy link
Contributor

erikn69 commented Sep 10, 2024

great 🎉🎉, it was very annoying

@barryvdh
Copy link
Collaborator Author

I know, right :p
Never enabled the button but really bugged me when I tried.

@erikn69
Copy link
Contributor

erikn69 commented Sep 10, 2024

but now I see that laravel-debugbar has its own file, this change will not be reflected there
And copy button was placed inline and the query end
image

@barryvdh
Copy link
Collaborator Author

Yes I was going to fix it in laravel-debugar in the new release, but first here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants