chore: Update golang to 1.18 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilien
approved these changes
Jun 14, 2022
|
OK so there was another PR upgrading to 1.17 which passes the tests. Can you rebase with the new merged code. Sorry about that. |
Aerex
force-pushed
the
chore/update-golang
branch
from
6061b25 to
665d469
Compare
Aerex
force-pushed
the
chore/update-golang
branch
from
2ef97e6 to
153ea83
Compare
|
/ok-to-test |
Aerex
force-pushed
the
chore/update-golang
branch
from
153ea83 to
2900be2
Compare
|
Merging and will try to figure out issue #58 which seems unrelated to your PR. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The repo is using a very old version of golang and we should look into updating to the latest if possible. This PR will remove the vendor files in favor of go modules via the
go.modfile.