Pair setup issues due to mDNS fix #123
Conversation
Put https://github.com/d4rkmen/esp-mdns in components/esp8266-rtos-sdk
mDNS configuration right after pair-setup response was reset controller pairing process. It moved to encrypted messages handler, where pairing is completed for sure
>>> HomeKit: [Client 2] Get Accessories !!! HomeKit: [Client 1] Error reading data from socket (code 113). Disconnecting >>> HomeKit: [Client 1] Closing client connection !!! HomeKit: [Client 2] Error reading data from socket (code 113). Disconnecting >>> HomeKit: [Client 2] Closing client connection
|
What is the rationale behind sockets setup fix? |
|
Why do you need a new “discoverable” variable which is just an inverse of “paired” variable? |
|
Oops. Sockets issue is not related to pairing. It should be separate PR. The problem is: when controller closes the connection at session end (this is normal) accessory still tries to read data from connection (due to keepalive settings?) |
Otherwise it will call mdns config every request, not once |
How do you know this is actually the case and you’re not making this up? How do you test? How do you know that this particular changes fix the problem? |
After I detected errors in logs (all the time) I have added some traces and found the error appers at the session end (phine closes connection). Then checked the HomeKitADK for socets setup as an instance.
Tested on your samples
After 24h testing - there was no errors in the log. This particular issue is gone, but not sure is there new ones (so far) As we all can see, thing works for one not 100% works for all |
Another mDNS implementation for RTOS SDK and mDNS configuration logic changed