added Find Place API call #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximn
requested changes
Dec 9, 2018
|
|
||
| AssertInconclusive.NotExceedQuota(result); | ||
| Assert.AreEqual(Status.OK, result.Status); | ||
| Assert.AreEqual("ChIJL3osJJksDogRodsJu9TjTQA", result.Candidates.FirstOrDefault()?.PlaceId); |
There was a problem hiding this comment.
This is very fragile, in a while (few months) the first candidate will have another ID and this test will break.
You can do something like
- have more than 1 candidate
- the first candidate has an ID longer than x (10?) characters
There was a problem hiding this comment.
ok, swapped the test with something similar to one of the place details test, and added one more test that seemed relevant.
|
Did you run these tests? Looks like failing - https://travis-ci.org/maximn/google-maps/builds/466175042 |
|
Crap, sorry. I have them passing now in my branch. Do I need to do a separate PR? |
|
Yes. |
|
Nuget - 0.78.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(2nd attempt)
Added the "Find Place" API call, request, and response classes.
https://developers.google.com/places/web-service/search#FindPlaceRequests
And added one unit test for now so something was there at least.