Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes #152

Closed
wants to merge 4 commits into from
Closed

Routes #152

wants to merge 4 commits into from

Conversation

avgolberg
Copy link

No description provided.

@gitguardian
Copy link

gitguardian bot commented Jul 23, 2022

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Google API Key ed45412 GoogleMapsWPF/MainWindow.xaml.cs View secret
- Google API Key ed45412 GoogleMapsWPF/MainWindow.xaml.cs View secret
- Google API Key 4de0f15 GoogleMapsWPF/MainWindow.xaml.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@maximn
Copy link
Owner

maximn commented Jul 24, 2022

Hi, I don't think that WPF should be part of this library. It's a standalone library that can be used in any type of a project.

BTW, note that you published your API keys, so please revoke them.

@maximn maximn closed this Jul 24, 2022
@avgolberg avgolberg deleted the routes branch July 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants