add StaticMapsEngine.GenerateStaticMapURL accept encode path
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an encoded polyline using the enc: prefix within the location declaration of the path
add use EncodePolyline example
|
modify readme.md commit also have some code file changes (spacing). please remove. |
maximn
reviewed
Aug 31, 2023
| @@ -28,13 +28,13 @@ public string GenerateStaticMapURL(StaticMapRequest request) | |||
|
|
|||
| var parametersList = new QueryStringParametersList(); | |||
|
|
|||
| if (!string.IsNullOrEmpty(request.ApiKey)) | |||
There was a problem hiding this comment.
Was this intentional? If not, please revert.
There was a problem hiding this comment.
Visual Studio automatically formatting it.
Could you tell me how to revert?
maximn
reviewed
Aug 31, 2023
| }; | ||
| var geocodingEngine = GoogleMaps.Geocode; | ||
| GeocodingResponse geocode = geocodingEngine.Query(geocodeRequest); |
There was a problem hiding this comment.
Is this should be part of this commit? Seems like unrelated.
There was a problem hiding this comment.
IEngineFacade only have QueryAsync method, so GeocodingResponse geocode = geocodingEngine.Query(geocodeRequest); should be changed to var geocode = await geocodingEngine.QueryAsync(geocodeRequest);
maximn
reviewed
Aug 31, 2023
| }); | ||
| Console.WriteLine("Map with path: " + url); | ||
|
|
||
| //use EncodePath |
maximn
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query=>QueryAsync...)StaticMapsEngine.GenerateStaticMapURLmethod, acceptencode path