Test Case(s) for creating a subscription awaiting_signup with metered components and restricted coupon
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimierzm-iRonin
force-pushed
the
FIRST-9
branch
3 times, most recently
from
f595172
to
5eb3788
Compare
maciej-nedza
requested review from
michalpierog,
patryk-grudzien-keen and
maciej-nedza
| s.Equal(subscription.CustomerId, createdSubscription.Customer.Id) | ||
| s.Equal(subscription.ProductId, createdSubscription.Product.Id) | ||
|
|
||
| listResp, err := s.client.SubscriptionComponentsController().ListSubscriptionComponents( |
There was a problem hiding this comment.
Is there some possibility in the SDK to provide only required parameters to avoid long list of nils?
Builder or some other pattern?
There was a problem hiding this comment.
Not in this version of sdk. We could use those parameters as options but that would require writing wrapper around sdk methods
michalpierog
approved these changes
Jan 22, 2024
kazimierzm-iRonin
force-pushed
the
FIRST-9
branch
from
5eb3788
to
fdd64d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.