Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE-617] Get rid of "Nullify404" code gen setting in APIMatic configuration and adjust tests #29

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

patryk-grudzien-keen
Copy link
Contributor

No description provided.

Copy link

swarmia bot commented Nov 23, 2023

Copy link
Contributor

@maciej-nedza maciej-nedza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patryk-grudzien-keen patryk-grudzien-keen merged commit 229c705 into main Nov 23, 2023
2 checks passed
@patryk-grudzien-keen patryk-grudzien-keen deleted the publish branch November 23, 2023 11:16
// then
assertThat(customerResponse).isNull();
// when - then
assertThatExceptionOfType(ApiException.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create custom assertion, e.g. assertNotFound(() -> ...) as this would be used in multiple tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in here: #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants