Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a problem with grow_memory #5

Closed
beProsto opened this issue Jan 8, 2022 · 1 comment
Closed

a problem with grow_memory #5

beProsto opened this issue Jan 8, 2022 · 1 comment

Comments

@beProsto
Copy link
Contributor

beProsto commented Jan 8, 2022

I've had a problem trying to compile this project with clang on windows.
Specifically during the compilation of malloc.c;
It seems like __builtin_wasm_grow_memory(pages) is no more in clang?
Instead i had to use __builtin_wasm_memory_grow(0, pages) :D

So my question is, as i can see this project was made for compilation on linux, does clang on linux have other builtins?
I don't have enough space on my hard drive to test that at the moment. :/

The other question of mine would be whether or not could you change it in the project? :D
Or if i can make a pull request or something changing it?

Or if, maybe, memory_grow is somehow different to grow_memory?

@maxkl
Copy link
Owner

maxkl commented Feb 14, 2022

Sorry, I somehow wasn't notified about this issue... It seems like the clang builtin function has indeed been renamed: WebAssembly/spec#627. You can go ahead and create a pull request if you like, I'd very much appreciate it!

beProsto added a commit to beProsto/wasm-malloc that referenced this issue Dec 29, 2022
Referring to maxkl#5
(Sorry for being a year late ^^')
@maxkl maxkl closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants