Sync delegate api changes + spire-api-sdk bump to 1.10.2
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is flagging some lints in files I didn't touch - opened #97 to fix those. |
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/sync-delegate-api-changes
branch
from
b0e60a7
to
103a752
Compare
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
changed the title
spire-api-sdk bump to 1.10.2
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/sync-delegate-api-changes
branch
from
31945eb
to
516857b
Compare
|
@maxlambrecht since 1.10.2 was cut today, resynced this. Should be good. Notably this does not add new integ tests for PID-based delegate selection - but there's not much new to test here other than the enum variants, which probably does not merit an integ test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spiffe/spire#5272 and spiffe/spire-api-sdk#58 changed the delegate API and proto slightly, this is just a bump to sync against that.
To be clear, this doesn't need to be merged until spire merges their
nextbranch intomainand cuts the next release https://github.com/spiffe/spire-api-sdk/tree/next but I'm getting this up so it's ready.