Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Mark bounced requests in access.log #186

Closed
dawidkulpa opened this issue Sep 7, 2024 · 2 comments · Fixed by #189
Closed

[FEATURE] Mark bounced requests in access.log #186

dawidkulpa opened this issue Sep 7, 2024 · 2 comments · Fixed by #189
Assignees
Labels
enhancement New feature or request

Comments

@dawidkulpa
Copy link

Is your feature request related to a problem? Please describe. 🐛
Currently, when a request is bounced, the only way to see that in access.log is by looking for "403" codes, but as you can imagine, this could also mean that the underlying app returned 403.

Describe the solution you'd like
Add a request header clearly stating if the request was blocked by crowdsec.

@maxlerebourg maxlerebourg self-assigned this Sep 15, 2024
@maxlerebourg maxlerebourg added the enhancement New feature or request label Sep 15, 2024
@maxlerebourg
Copy link
Owner

Hey, it's an excellent idea, let's do it.
What do want to expose ? The request decision (Header CS-Decision: ban (or captcha)) or just the fact that the bouncer has block this request (Header CS-Decision: 1)

@mathieuHa
Copy link
Collaborator

Yeah, like max said, we could add it in the plugin, but I think by default it should be disabled.
Adding information in the response can give an attacker information that the product Crowdsec has blocked the request. So it should be activated by the admin knowingly.

We're open to PR if you wan't try to add it, otherwise we will try to do it when we get some free time to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants