Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add remediation header when plugin made decision #189

Merged
merged 2 commits into from
Sep 25, 2024
Merged

✨ add remediation header when plugin made decision #189

merged 2 commits into from
Sep 25, 2024

Conversation

maxlerebourg
Copy link
Owner

No description provided.

@maxlerebourg maxlerebourg linked an issue Sep 24, 2024 that may be closed by this pull request
[FEATURE] Mark bounced requests in access.log #186
Closed
@maxlerebourg maxlerebourg self-assigned this Sep 24, 2024
mathieuHa
mathieuHa approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@mathieuHa mathieuHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this looks good, only thing that could be added maybe is a test with the header set and without it

@maxlerebourg maxlerebourg merged commit 45d5f38 into main Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieuHa mathieuHa mathieuHa approved these changes

Assignees

@maxlerebourg maxlerebourg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Mark bounced requests in access.log
2 participants
@maxlerebourg @mathieuHa