Inline and optimize some decoding methods to improve performance #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlined and optimized sizeFromCtrlByte and decodePointer. Reduces object churn on return values and also improves JIT inlining patterns. Net speedup on benchmark 10-15%.
|
While the test coverage tool indicates a decrease, it's simply because the number of lines was reduced. The effective coverage is still the same, so this check should pass. |
|
Thanks! I am seeing a 5-7% speedup with this on the included benchmark. |
oschwald
added a commit
that referenced
this pull request
Dec 26, 2015
Inline and optimize some decoding methods to improve performance
|
Thanks for merging! Submitted some benchmark improvements in #19 to get more consistency in measurements. For this change (#18), on my 2011 MacbookPro 2.2Ghz i7, Java 1.8.0_66 HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode), I've measured a baseline of ~69k ops/s, which improved to ~78k ops/s after this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlined and optimized sizeFromCtrlByte and decodePointer. Reduces object churn on return values (see #13) and also improves JIT inlining patterns.
Net speedup on benchmark 10-15%.