Do not depend on non-core Perl modules #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
force-pushed
the
greg/core-only-man-page-generation
branch
from
2bbaf08 to
a09fa4b
Compare
horgh
requested changes
Dec 11, 2024
| my $header = read_file("$Bin/../include/maxminddb.h"); | ||
| open my $header_fh, '<', "$Bin/../include/maxminddb.h" | ||
| or die "Failed to open header file: $!"; | ||
| my $header = do { local $/; <$header_fh> }; |
There was a problem hiding this comment.
Is it possible to error check the read? I think I've used if defined $header in the past.
| $file, | ||
| ); | ||
| open my $fh, '<', $file or die "Failed to open man file for reading: $!"; | ||
| my @lines = <$fh>; |
There was a problem hiding this comment.
As above, although it's less clear to me how to error check in this case.
|
Possibly these are overly pedantic. I'm okay merging too :-P |
horgh
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.