Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding A/AAAA DNS discovery for cluster peers #61

Merged
merged 2 commits into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stream/embedded_nats.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ func startEmbeddedServer(nodeName string) (*embeddedNats, error) {
}
}

if len(opts.Routes) != 0 {
opts.Routes = discoverAndFlattenRoutes(opts.Routes)
}

if opts.StoreDir == "" {
opts.StoreDir = path.Join(cfg.DataRootDir, "nats", nodeName)
}
Expand Down
124 changes: 124 additions & 0 deletions stream/routes_discover.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
package stream

import (
"fmt"
"net"
"net/url"
"strconv"
"strings"
"time"

"github.com/rs/zerolog/log"
"github.com/samber/lo"
)

func discoverAndFlattenRoutes(urls []*url.URL) []*url.URL {
ret := make([]*url.URL, 0)
for _, u := range urls {
if u.Scheme == "dns" {
ret = append(ret, discoverPeers(u)...)
continue
}

ret = append(ret, u)
}

return ret
}

func discoverPeers(u *url.URL) []*url.URL {
minPeerStr := u.Query().Get("min")
intervalStr := u.Query().Get("interval_ms")

minPeers, err := strconv.Atoi(minPeerStr)
if err != nil {
minPeers = 2
}

interval, err := strconv.Atoi(intervalStr)
if err != nil {
interval = 1000
}

log.Info().
Str("url", u.String()).
Int("min_peers", minPeers).
Int("interval", interval).
Msg("Starting DNS A/AAAA peer discovery")

for {
peers, err := getARecordPeers(u)
if err != nil {
log.Error().
Err(err).
Str("url", u.String()).
Msg("Unable to discover peer URLs")
time.Sleep(time.Duration(interval) * time.Millisecond)
continue
}

urls := strings.Join(
lo.Map[*url.URL, string](peers, func(i *url.URL, _ int) string { return i.String() }),
", ",
)
log.Info().Str("urls", urls).Msg("Peers discovered")

if len(peers) >= minPeers {
return peers
} else {
time.Sleep(time.Duration(interval) * time.Millisecond)
}
}
}

func getARecordPeers(u *url.URL) ([]*url.URL, error) {
v4, v6, err := queryDNS(u.Hostname())
if err != nil {
return nil, err
}
var ret []*url.URL
for _, ip := range v4 {
peerUrl := fmt.Sprintf("nats://%s:%s/", ip, u.Port())
peer, err := url.Parse(peerUrl)
if err != nil {
log.Warn().
Str("peer_url", peerUrl).
Msg("Unable to parse URL, might be due to bad DNS entry")
continue
}
ret = append(ret, peer)
}

for _, ip := range v6 {
peerUrl := fmt.Sprintf("nats://[%s]:%s/", ip, u.Port())
peer, err := url.Parse(peerUrl)
if err != nil {
log.Warn().
Str("peer_url", peerUrl).
Msg("Unable to parse URL, might be due to bad DNS entry")
continue
}
ret = append(ret, peer)
}

return ret, nil
}

func queryDNS(domain string) ([]string, []string, error) {
ips, err := net.LookupIP(domain)
if err != nil {
return nil, nil, err
}

var ipv4 []string
var ipv6 []string
for _, ip := range ips {
if v4 := ip.To4(); v4 != nil {
ipv4 = append(ipv4, v4.String()) // A record
} else if v6 := ip.To16(); v6 != nil {
ipv6 = append(ipv6, v6.String()) // AAAA record
}
}

return ipv4, ipv6, nil
}