avoid spamming email inboxes. hotfix, deployed to production 😳

maxplanck-ie · Sep 24, 2024 · 10e0242 · 10e0242
1 parent ec514ed
commit 10e0242
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 ========
 
 - TODO: `<URL>/export_request/` and `<URL>/import_request/` both have a simple UI
+- E-mail communications: grayed-out "send" button after 1 click, to avoid spamming inboxes.
 - Fixtures: save_initial_data management cmd will use built-in json formatter instead of `jq`.
 - ...
 

diff --git a/backend/static/main-hub/app/view/requests/EmailWindowController.js b/backend/static/main-hub/app/view/requests/EmailWindowController.js
@@ -31,6 +31,9 @@ Ext.define("MainHub.view.requests.EmailWindowController", {
       return;
     }
 
+    btn.setDisabled(true);
+    btn.setText("Sending...");
+
     form.submit({
       url: Ext.String.format(
         "api/requests/{0}/send_email/",
@@ -47,6 +50,8 @@ Ext.define("MainHub.view.requests.EmailWindowController", {
           : action.response.statusText;
         new Noty({ text: error, type: "error" }).show();
         console.error(action);
+        btn.setDisabled(false);
+        btn.setText("Send");
       }
     });
   }

diff --git a/backend/static/main-hub/app/view/requests/TokenWindowController.js b/backend/static/main-hub/app/view/requests/TokenWindowController.js
@@ -31,6 +31,9 @@ Ext.define("MainHub.view.requests.TokenWindowController", {
       return;
     }
 
+    btn.setDisabled(true);
+    btn.setText("Sending...");
+
     form.submit({
       url: Ext.String.format(
         "api/requests/{0}/solicit_approval/",
@@ -47,6 +50,8 @@ Ext.define("MainHub.view.requests.TokenWindowController", {
           : action.response.statusText;
         new Noty({ text: error, type: "error" }).show();
         console.error(action);
+        btn.setDisabled(false);
+        btn.setText("Send");
       }
     });
   }