-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests directory to source tarball #108
Comments
Hi Benjamin, You mean the tarball which you get from PyPI, like this one for v1.2.0 ? |
Yes, exactly. |
Done. You can now also use python setup.py test command which will figure out all the dependencies needed for running tests on the current system and after installing them if they are not here it will run the tests. Also starting from v1.4.0 requests are now bundled with Python-Redmine and will be updated as needed. That will make package much more stable. Let me know if everything works for you as it should. |
Please do not bundle needed libraries into your package. The Debian package will always use python-request from the system. Bundled libraries have the drawback that they increases the source package size and that I have to document also their license. See also https://wiki.debian.org/UpstreamGuide#No_inclusion_of_third_party_code |
I'm sorry but I fully disagree.
Python-Redmine exists for more than 1.5 years now and I had several bug reports connected with the wrong Requests library version on the system, which was very hard to identify. Also, a lot of packages bundle other packages and that is a fact of life, because bundling makes the developer life easier and it also provides users of the package with the best possible experience. For example take the Requests library, it bundles I really appreciate your work for making Python-Redmine available in Debian and Ubuntu, but bundling libraries makes life better, not worse, that is why I'm not going to change my mind about this. |
@bdrung There is an ongoing discussion in the #109 about whether it was a good idea to bundle I'm closing this issue because it is related to tests and we figured everything about them already. |
Please add the tests directory to source tarball, since we use that for the Debian package. Otherwise the tests cannot be run from the source tarball.
The text was updated successfully, but these errors were encountered: