Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use currentColor #7

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Use currentColor #7

merged 1 commit into from
Aug 21, 2024

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Aug 9, 2024

When using the generated SVGs they're always black, even if CSS tries to set a hover/active colour. This changes it to instead us currentColor so that it inherits the colour when color: is specified in CSS.

When using the generated SVGs they're always black, even if CSS tries to set a hover/active colour. This changes it to instead us `currentColor` so that it inherits the colour when `color:` is specified in CSS.
@maxwellito
Copy link
Owner

Hi there,
Sorry about the delay, I was AFK for a while. Thanks for your PR, really appreciate.
The changes seems legit to me, have you tried it with dark mode? I believe it should work because the dark mode is only a CSS filter to invert colors. Thanks

@tomjn
Copy link
Contributor Author

tomjn commented Aug 21, 2024

Just a quick test:

Screenshot 2024-08-21 at 13 08 16

I was hoping to adjust the background dot grid so its element was removed rather than hidden on save but thought it best to keep things simple

Copy link
Owner

@maxwellito maxwellito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your fix

@maxwellito maxwellito merged commit 08e12ca into maxwellito:main Aug 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants