Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form labels #1004

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Fix form labels #1004

merged 4 commits into from
Jul 22, 2024

Conversation

tonyvince
Copy link
Contributor

Fix #1001

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice solution here!

I like this as our fallback, but I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of?

@tonyvince
Copy link
Contributor Author

I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of?

Not sure I understand what you mean fully but label: true as we have here is the automaded way of handling them via model translation. A custom label like label: t(".email") will still work with this solution

@zachgoll
Copy link
Collaborator

@tonyvince my bad, I see what you mean now! I had missed that piece of logic when updating the forms.

@zachgoll zachgoll merged commit f62c5e4 into maybe-finance:main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Form Text Labels Display Incorrect Text on Account Creation Page
2 participants