Fix account transaction form resetting amount to 0 #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgoll
commented
Aug 26, 2024
| @@ -12,8 +12,7 @@ def index | |||
| end | |||
|
|
|||
| def update | |||
| @entry.update!(entry_params.merge(amount: amount)) | |||
| @entry.sync_account_later | |||
There was a problem hiding this comment.
Removed the sync_later because this triggers a refresh of the entire page (via the Sync broadcasts) which gets annoying for updating transaction details. This will cause out-of-sync data if the user changes the amount or date, but will be updated on the next sync.
Eventually we'll want to get more granular with when we trigger the re-sync, but for now this feels like a decent tradeoff.
zachgoll
commented
Aug 26, 2024
| @@ -12,8 +12,7 @@ def index | |||
| end | |||
|
|
|||
| def update | |||
| @entry.update!(entry_params.merge(amount: amount)) | |||
There was a problem hiding this comment.
Merging in amount caused the scenario when we didn't include the param, it was calling nil.to_d, which resulted in 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132