Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up some basic "exceptions" for formatting currencies.
As of now, we format currencies in the UI based on the following logic:
Money
andMoney::Currency
classes read this list and provide a method,format_options
format_currency
which uses Railsnumber_to_currency(format_options)
to format the currencyThis works in 95% of cases, but there are some cases where a single currency like
EUR
should be formatted differently based on the locale of the user.#1226 enabled setting locales for each user. We are now able to pass the configured locale directly to the
format_options
method on theMoney
class to "override" the default formatting.For example,
25123.98
in theEUR
currency will be formatted as follows based on the user's locale:€25,123.98
- foren
€25.123,98
- forde
This PR will certainly not cover all exceptional cases, but sets up an easy way to add these via
locale_options
: