Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to categories & changelog pages #1274

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

arsenstorm
Copy link
Contributor

Hey there!

I’m testing the hosted version of Maybe, and a few things bothered me regarding the UI.

The grey border around the badges for the categories feels wrong. I’ve updated this to match the colour of the badge instead.

Before:

Screenshot 2024-10-09 at 21 38 30

After:

Screenshot 2024-10-09 at 21 38 55

It also feels a bit wrong to see the name of the changelog update instead of the person who created the release.

Before:

Screenshot 2024-10-09 at 21 42 09

After:

Screenshot 2024-10-09 at 21 41 31

@arsenstorm arsenstorm marked this pull request as draft October 9, 2024 20:45
@arsenstorm arsenstorm marked this pull request as ready for review October 9, 2024 20:45
@zachgoll
Copy link
Collaborator

zachgoll commented Oct 9, 2024

@arsenstorm thanks for the updates!

@justinfar will have to approve these as I'm not the best with design :)

@arsenstorm
Copy link
Contributor Author

arsenstorm commented Oct 9, 2024 via email

@justinfar
Copy link

Hey @arsenstorm thanks so much for looking into this

Re changing the name to show the person who created the release, 100% agree

Re the border color, initially I had the alpha-black/25 that blended with the background which gave it a darkened category background color which is exactly what you're doing here (albeit slightly more subdued)

Figma handles borders/strokes differently in comparison to actual CSS so this probably got a bit lost in translation.

So overall agree on the change, only thing I'd change is the to make the border slightly lighter and perhaps change from 25% to 30% over here:

border-color: color-mix(in srgb, <%= category.color %> 25%, white);

If you have other UI bits that you think could be improved feel free to let us know :)

@arsenstorm
Copy link
Contributor Author

Ah I see

I think switching 25% -> 30% does make it slightly nicer

Another option is to make it borderless which would align better with the tags and merchants page; however, I personally feel like the badges on these pages would benefit more with a border (or a slightly darker background)

@zachgoll zachgoll merged commit 77fc5ca into maybe-finance:main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants