Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock imports #1363

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Stock imports #1363

merged 7 commits into from
Oct 24, 2024

Conversation

Shpigford
Copy link
Member

Sets the foundation for adding Marketstack as a data provider for non-US stocks.

This is primarily focused on populating the Securities table with all global stocks in the hosted version, but lays the groundwork for pulling prices as well as letting self-hosters only import specific exchanges.

@Shpigford Shpigford requested a review from zachgoll October 24, 2024 19:13
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup looks good to me!

app/models/provider/marketstack.rb Outdated Show resolved Hide resolved
app/jobs/securities_import_job.rb Outdated Show resolved Hide resolved
@Shpigford
Copy link
Member Author

@zachgoll Any other changes you'd want made before this gets pushed?

Next PR will be actually setting up appropriate importing based on hosted vs self-hosted. So this on its own doesn't actually make any data additions (just db schema).

@zachgoll
Copy link
Collaborator

@Shpigford yeah I think we're all set for this first step here

@Shpigford Shpigford merged commit aa3342b into main Oct 24, 2024
5 checks passed
@Shpigford Shpigford deleted the stock-imports branch October 24, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants