SimpleCov Coverage Report

[Harry-kp]

Description

fixes #699

• This PR adds the functionality of generating a Code Coverage Report in Simple HTML format. The generation of code coverage is based on the ENV variable which is defaulted to true (meaning a report will be generated every time when the test runs).

[zachgoll]

I pulled this down locally and ran it and for some reason, was getting some odd results. For example:

We have test/models/upgrader_test.rb which tests a majority of upgrader.rb, but this coverage report shows 0% coverage.

Are you seeing a similar result locally?

[zachgoll]

I think simplecov should only be in the :test group right?

Also, I recently moved dotenv-rails to the :development group only to avoid unexpected, failing tests when a dev has their .env setup incompatible with the test expectations. I think this will still work if we pass the ENV to the test command right?

[Harry-kp]

Yes, this should be in the test group and it works if we pass the env from the CMD. Working on changes

[zachgoll]

@harrrykp also, for future PRs, would you mind configuring your Github email (in settings) to match your git client email? It makes it a little easier to review with a single user in the commit history.

[zachgoll]

See: simplecov-ruby/simplecov#718

Looks like Rails test parallelization is causing coverage to drop:

parallelize(workers: :number_of_processors)

We should be seeing ~85% coverage on this codebase.

[Harry-kp]

I pulled this down locally and ran it and for some reason, was getting some odd results. For example:

We have test/models/upgrader_test.rb which tests a majority of upgrader.rb, but this coverage report shows 0% coverage.

Are you seeing a similar result locally?

Yes, happening same on my local.

[Harry-kp]

See: simplecov-ruby/simplecov#718

Looks like Rails test parallelization is causing coverage to drop:

parallelize(workers: :number_of_processors)

We should be seeing ~85% coverage on this codebase.

Ohh, got it. Will be reviewing this issue for a possible solution.

[Harry-kp]

@harrrykp also, for future PRs, would you mind configuring your Github email (in settings) to match your git client email? It makes it a little easier to review with a single user in the commit history.

Sure @zachgoll , need to check my git configs. Will fix this behaviour in future PRs.

[zachgoll]

@harrrykp closing this out for now. If you'd like to continue work on it just let me know and I'll re-open!