Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Apple Silicon processors #84

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RodriguesCosta
Copy link

Today I downloaded the latest build available and I noticed that I need rosette 2 to work, although rosette 2 works very well, it doesn't hurt to add native support for apple silicon processors

added support for arm64 builds
@daltonmenezes
Copy link
Collaborator

daltonmenezes commented Sep 23, 2022

Hi @RodriguesCosta , thanks for your contribution, but as the app is packaged from GitHub Actions, there's no VM support to Apple Silicon yet, this PR will remain open until support on GitHub Action for Apple Silicon VM is complete! I really don't know if Electron Builder will break trying to do this in a x64 platform and I don't have an Apple machine with Apple Silicon to test this properly, maybe the other maintainers can help us on this

@diego3g @maykbrito

@RodriguesCosta
Copy link
Author

Hi @daltonmenezes, my mistake. I bought a mac with M1 literally 4 days ago. I forgot to check if the problem was the github actions, but I can guarantee that the build works on a mac with an m1 processor, and I'm already using the build!

I will take the time to create an x64 virtual machine and test the build.

@daltonmenezes
Copy link
Collaborator

@RodriguesCosta no problem, thanks, and please tell us about your progress in this test in a x64 virtual machine build 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants