🔒️ Removing private key when certificate has been verified and uploaded #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For security purposes, it's better to remove the private key from the signing request instance as it is now store encrypted on the client system.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 90.08% 90.10% +0.02%
==========================================
Files 14 14
Lines 474 475 +1
Branches 72 72
==========================================
+ Hits 427 428 +1
Misses 42 42
Partials 5 5 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Sep 19, 2024
sergei-maertens
deleted the
issue-45-remove-pk-when-certificate-uploaded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
For security purposes, it's better to remove the private key from the signing request instance as it is now store encrypted on the client system.
I have based this branch on #48