Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Replace dependencies with open-api-framework deps #93

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 26, 2024

@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch 2 times, most recently from a9d2e5c to eaf6c3d Compare January 26, 2024 12:40
@stevenbal stevenbal marked this pull request as draft January 26, 2024 12:40
@stevenbal stevenbal changed the title ➕ Replace dependencies with open-api-framework deps [Draft] ➕ Replace dependencies with open-api-framework deps Jan 26, 2024
@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch from eaf6c3d to eebef61 Compare January 26, 2024 13:11
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (552b21e) 94.97% compared to head (680be6b) 94.95%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/objecttypes/utils/autoschema.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   94.97%   94.95%   -0.02%     
==========================================
  Files          88       88              
  Lines        1889     1883       -6     
==========================================
- Hits         1794     1788       -6     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch 5 times, most recently from 1937ceb to b163221 Compare January 30, 2024 15:31
@stevenbal stevenbal changed the title [Draft] ➕ Replace dependencies with open-api-framework deps ➕ Replace dependencies with open-api-framework deps Jan 30, 2024
@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch from b163221 to 6f6063d Compare February 6, 2024 15:19
@stevenbal stevenbal marked this pull request as ready for review February 6, 2024 15:21
@alextreme
Copy link
Member

ModuleNotFoundError: No module named 'sniplates'
Error: Process completed with exit code 1.

@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch from 6f6063d to 680be6b Compare February 12, 2024 10:44
@annashamray
Copy link
Collaborator

As discussed on Slack let's:

@annashamray
Copy link
Collaborator

@stevenbal maykinmedia/objects-api#362 is merged, so this branch can be rebased on master

@stevenbal stevenbal force-pushed the feature/open-api-dependencies branch from 680be6b to 18da319 Compare April 12, 2024 07:55
@stevenbal stevenbal marked this pull request as draft April 12, 2024 07:56
@stevenbal stevenbal marked this pull request as ready for review April 12, 2024 08:03
@stevenbal
Copy link
Contributor Author

@annashamray this PR is ready for review again

Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@annashamray annashamray merged commit b06d5c6 into master Apr 15, 2024
8 checks passed
@annashamray annashamray deleted the feature/open-api-dependencies branch April 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Open API framework to Objecttypes API
4 participants