Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3045] Add option to enable/disable indexing by search engines #1623

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma marked this pull request as ready for review February 14, 2025 12:22
@pi-sigma pi-sigma requested a review from swrichards February 14, 2025 12:22
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but two points:

  1. We also have a base_pdf.html which might also avail itself of the flag.
  2. We also have a bunch of error templates (403.html, etc). While we're doing this, it would make sense to me to simply add a static noindex to those (search engines should never pick those up, regardless of the environment).

@pi-sigma pi-sigma force-pushed the task/3045-search-index branch from cfb57b0 to a62e471 Compare February 17, 2025 09:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (ad1cb55) to head (e0d3fa3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1623   +/-   ##
========================================
  Coverage    94.20%   94.20%           
========================================
  Files         1081     1083    +2     
  Lines        39958    39985   +27     
========================================
+ Hits         37642    37669   +27     
  Misses        2316     2316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma requested a review from swrichards February 17, 2025 10:20
@pi-sigma pi-sigma marked this pull request as draft February 17, 2025 10:33
@pi-sigma pi-sigma force-pushed the task/3045-search-index branch from a62e471 to 9a85c6b Compare February 17, 2025 14:18
@pi-sigma pi-sigma force-pushed the task/3045-search-index branch from 9a85c6b to e0d3fa3 Compare February 17, 2025 16:45
@pi-sigma pi-sigma marked this pull request as ready for review February 18, 2025 07:21
@pi-sigma pi-sigma requested a review from swrichards February 18, 2025 07:21
@swrichards swrichards merged commit e9cf977 into develop Feb 18, 2025
22 checks passed
@swrichards swrichards deleted the task/3045-search-index branch February 18, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants