Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default config #634

Closed
wants to merge 3 commits into from

Conversation

free-bots
Copy link
Contributor

this pr includes changes of #633 and allowes to share a configuration across multiple clients, if no configuration was provided localstorage will be used like before
open points:

@mayswind
Copy link
Owner

mayswind commented Dec 20, 2021

I'm afraid I cannot merge this pr, because it is not secure when aquiring data which may have sensitive config. So AriaNg does not provide this method to reduce careless behavior. In the other hand, AriaNg provides command api to allow people to set rpc server conveniently and clearly.
By the way, #633 is great, and I would merge it before the next release of AriaNg.

@mayswind mayswind closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants