Added custom headers support for Aria2 RPC HTTP(s) requests #638
Conversation
| @@ -66,6 +66,18 @@ | |||
| requestContext.url = getUrlWithQueryString(requestContext.url, context.requestBody); | |||
| } | |||
|
|
|||
| var options = ariaNgStorageService.get(ariaNgConstants.optionStorageKey); | |||
There was a problem hiding this comment.
You should not import ariaNgStorageService into this service, because ariaNgSettingService is the unique interface for other service/controller getting/setting option value. You should put a method like getCurrentRpcHttpRequestHeaders into ariaNgSettingService, this method should return a array containing all request headers. I think you can refer to getCurrentRpcUrl or getCurrentRpcDisplayName method.
By the way, I think you should also put a default option value (maybe a empty string "") into scripts/config/constants.js
| @@ -66,6 +66,18 @@ | |||
| requestContext.url = getUrlWithQueryString(requestContext.url, context.requestBody); | |||
| } | |||
|
|
|||
| var options = ariaNgStorageService.get(ariaNgConstants.optionStorageKey); | |||
| if (options.httpHeader) { | |||
| var lines = options.httpHeader.split("\n"); | |||
|
another commit has been committed, so this pr would be closed |
Could you please provide the commit number you mentioned? |
|
This PR will add a "Aria2 RPC Http Request Header" option in AriaNg settings, which allows users to customize the headers of each RPC HTTP request.
Some users use the Cloudflare Access service to block others from illegally accessing their NAS at home, thereby improving the security of the home network. That service usually requires users to log in with OAuth for authentication. For automation or CI programs, users can also add specific headers(
CF-Access-Client-IdandCF-Access-Client-Secret) to the http request to pass the verification of Cloudflare.So this PR will benefit users similar to the above scenarios.