-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with React versions >16 #89
Comments
@tconroy If you need to override peer dependencies of your dependencies, npm >v8.3 supports {
"dependencies": {},
"devDependencies": {},
"overrides": {
"@harelpls/use-pusher": {
"react": "^17.0.2"
}
},
} |
As an alternative to @Naartti `s solution, just ignore the legacy peers using: npm install --save @harelpls/use-pusher --legacy-peer-deps Hope the dependencies will get updated shortly. |
This worked on my local but fails when i push to vercel. I think i can fork the package and bump the react dependency and make a PR - is anyone accepting PRs these days? |
Strange it didn't work: yarn install v1.22.19 |
Describe the bug
This package seems to be constrained to a React peer dependency if 16.x, making it incompatible with React 17 and 18 codebases.
I could find no reason in the code for this limitation. Any chance we could loosen up the peer dependency constraint to allow newer react projects to use this hook? :)
The text was updated successfully, but these errors were encountered: