Improve clearing the current console line #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear the previously written line instead of clearing the whole console window width. This way, when resizing the console window, lines don't wrap.
|
Thank you for your contribution! This fix looks really good to me. |
|
Thanks for merging and releasing a new version so quickly ! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the previously written line instead of clearing the whole console window width. This way, when resizing the console window, lines don't wrap.
Here's a GIF to better understand what happens. The first two message batches use the console width (code before this commit). The last two message batches use the new code that clear only what's needed. Dots have been added (second and fourth samples) instead of spaces to better see why line wraps.