added 21-github #97
Open
added 21-github #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mazipan, I have added Github. Please check. Thanks. |
mazipan
requested changes
Oct 25, 2021
README.md
Outdated
| @@ -125,6 +125,18 @@ https://mazipan.github.io/login-page-css/ | |||
| - [Demo](https://mazipan.github.io/login-page-css/19-whatsapp/index.html) | |||
| - [@abhj](https://github.com/abhj) | |||
|
|
|||
| ### Twitter Login Page | |||
There was a problem hiding this comment.
can we revert all changes related with Twitter here?
make the pull request cleaner to not include another PR.
There was a problem hiding this comment.
Hi @mazipan, I have made the pull request cleaner to not include another PR. Please check. Thanks.
|
Fix the conflict |
|
Hi @mazipan, I have fixed the conflict and merged. Please check. Thanks. |
mazipan
reviewed
Oct 25, 2021
| <div class="row"> | ||
| <div class="text-center"> | ||
| <div class="col-xs-12 col-md-4 col-md-offset-4"> | ||
| <a href=""><img style="margin-left:auto; margin-right:auto; display: block" src="../assets/logo.png" alt="github_logo" width="70px" height="70px"><span></span></a> |
There was a problem hiding this comment.
As my previous comments, avoid using inline styles
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| </head> | ||
| <body style="background-color: #F9F9F9;"> | ||
| <link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"> |
There was a problem hiding this comment.
Avoid using Bootstrap, try to create from scratch
| <a href=""><img style="margin-left:auto; margin-right:auto; display: block" src="../assets/logo.png" alt="github_logo" width="70px" height="70px"><span></span></a> | ||
| <br> | ||
| <p style="font-family: segoe UI; font-size: 24px; color:#333333; font-weight: 400px;"> Sign in to GitHub </p> | ||
| <br> |
There was a problem hiding this comment.
Avoid using <br/> as much as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Twitter Login Template. This page is built using plain HTML and CSS.
Issue Reference
Closes #96
Screenshoot
Todos
screenshootsdirectoryreadme.mdsrc/index.htmlMinimum Support
Consider to Support