This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
fix: Non personalized ads TypeError #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for raising your pull request. Please make sure you have followed @mazipan And please push ⭐ button in this repository |
mazipan
approved these changes
Jun 25, 2020
|
Released 1.8.3 |
|
@all-contributors please add @schneefux for code and bug |
|
I've put up a pull request to add @schneefux! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a65b8f3 broke non personalized ads.
(adsbygoogle = window.adsbygoogle || []).push({}).requestNonPersonalizedAds = 1;is not valid, becausepush()returns the length of the array (see MDN).This won't show any ads for NPA users or trigger
TypeError: Cannot set property 'requestNonPersonalizedAds' of undefinedfor some users.see also https://support.google.com/adsense/answer/9042142?hl=en