Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint設定 #124

Merged
merged 13 commits into from
Apr 7, 2023
Merged

golangci-lint設定 #124

merged 13 commits into from
Apr 7, 2023

Conversation

mazrean
Copy link
Owner

@mazrean mazrean commented Apr 7, 2023

1.18リリース直後でジェネリクスに対応していなかったためgolangci-lintを使用していなかったが、特に問題がなくなったためgolangci-lintを導入した。
linterは厳しめになるように選んでおり、普段使わないようなものも含むため、不要と感じたら削除するかも。

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d71840) 32.53% compared to head (3439912) 32.53%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   32.53%   32.53%           
=======================================
  Files          23       23           
  Lines        5228     5228           
=======================================
  Hits         1701     1701           
  Misses       3346     3346           
  Partials      181      181           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mazrean mazrean merged commit da30f56 into main Apr 7, 2023
@mazrean mazrean deleted the dev/add-golangci-lint branch April 7, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants