Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when parsing hex value with non-ASCII #7

Merged
merged 1 commit into from
May 14, 2022

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Oct 31, 2021

Previously, the string slicing below would panic because they hit invalid UTF8 characters

@5225225
Copy link
Contributor Author

5225225 commented May 14, 2022

Is there anything I can do to help get this merged @mazznoer ?

I'm fuzzing https://github.com/wez/wezterm's escape parser, and am running into this panic, since it uses csscolorparser::parse. I'm assuming it can be mitigated against with some checks on wezterm's end, but would be good to not have anyone else run into this.

@wez
Copy link

wez commented May 14, 2022

wez/wezterm@a22942a works around this issue in the meantime

@mazznoer mazznoer merged commit 7ac8b28 into mazznoer:master May 14, 2022
@5225225 5225225 deleted the fix-parse-error branch August 15, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants