Remove identical generated themes with different casing #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2023
package hash differs between operating systems due to file system case sensitivity
ziglang/zig#18089
Closed
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were 3 generated themes in Alacrity and VScode that were named identically but with different casing. This can cause issues on case-insensitive filesystems, for example checksumming the repository after a git clone results in different hashes.
Because these were already identical themes and only in the generated themes (not the source schemas), I removed the conflicting files. The existing files matching the original scheme names still exist so future generations won't recreate them.
Just repeating that the files I deleted still exist just with a different case so I didn't remove any themes. For example, I deleted
alacritty/Darkmatrixbutalacritty/darkmatrixis still present (and that matchesschemes/darkmatrix). So this merge results in no loss of information.