Fix oxocarbon color theme colors #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dont merge this just yet |
|
ok we good. |
|
Thank you! |
|
Does it need an updated screenshot? |
No the screenshot is fine, i just exported the wrong theme from iterm2 originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the pull request where I added the Oxocarbon theme, the colors were broken for some reason in the generated files, they should be fixed in this pull request. I have loaded them in my terminal to ensure they match the screenshot.
Theme Submission Checklist
README.mdwith new theme and screenshotCREDITS.mdwith new themetools/gen.pyto generate themes in all formatsscreenshots/README.mdwith new theme