Fixing special char encoding (axios#1671)

* removing @ character from replacement list since it is a reserved character * Updating buildURL test to not include the @ character * Removing console logs Co-authored-by: Jay <jasonsaayman@gmail.com>
mbargiel · May 27, 2020 · 8e9490b · 8e9490b
1 parent 988957e
commit 8e9490b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/helpers/buildURL.js b/lib/helpers/buildURL.js
@@ -4,7 +4,6 @@ var utils = require('./../utils');
 
 function encode(val) {
   return encodeURIComponent(val).
-    replace(/%40/gi, '@').
     replace(/%3A/gi, ':').
     replace(/%24/g, '$').
     replace(/%2C/gi, ',').

diff --git a/test/specs/helpers/buildURL.spec.js b/test/specs/helpers/buildURL.spec.js
@@ -36,8 +36,8 @@ describe('helpers::buildURL', function () {
 
   it('should support special char params', function () {
     expect(buildURL('/foo', {
-      foo: '@:$, '
-    })).toEqual('/foo?foo=@:$,+');
+      foo: ':$, '
+    })).toEqual('/foo?foo=:$,+');
   });
 
   it('should support existing params', function () {