-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumpver doesn't recognise tagged versions as lower #242
Comments
I think this is expected yes. We have no logic of our own to determine old/new, we just use See: |
Hi @mbarkhau I have a follow-up question- Both PEP-440 and the up-to-date version-specifiers addressed:
So I think |
My guess is, if the "v" prefix is removed, and perhaps also the "-", then it might work. |
I still think there's a bit of an issue, but to update, I think in this case part of it was problems with my git tags. Since I was just getting it set up and experimenting, there were quite a few nonsensical things (out of order tags, lots of dev, rc, etc. tags) which could have confused bumpver and now with things cleaned up it's mostly working the way I would expect. But what I'd request is an option to override the old/new invariant, particularly when setting explicitly with |
If you used |
Yeah, something like that would be useful (with appopriate caveats, maybe even asking for confirmation before proceeding). Since one of the uses of a tool like For a legit example of this, say I have forked another project that is no longer maintained/is archived to make my own version of it. I'd want to reset the version number to v0.1.0, not caring about the fact that it's moving backwards. If they set it up with bumpver pointing to the relevant files, I should be able to just do |
Ok, it appears you've stumbled upon a genuine issue related to the Related: #156 |
This breakage starts with |
Have a look at |
## BumpVer 2024.1130 This update adds the vendored module `setuptools_v65_version.py` from `setuptools==v65.7.0`. This was the last version with support for `LegacyVersion`. - Fix [#242][gh_i242]: Fix incorrect parsing of versions with tags. - Fix [#156][gh_i156]: Remove runtime dependency on setuptools and looseversion. [gh_i242]: mbarkhau/bumpver#242 [gh_i156]: mbarkhau/bumpver#156 Thank you [Andrew Mitchell](https://github.com/MitchellAcoustics) and [Tzu-Ting](https://github.com/tzing) for your issue reports.
Please do correct me if I'm wrong, but my impression is tags, particularly prerelease tags like dev, a, b, rc, etc. should be considered lower than the base version, i.e.: 0.1.0 > 0.1.0-rc1. However, when trying to move from a prerelease to final version, bumpver throws an error:
Is this the expected behaviour?
The text was updated successfully, but these errors were encountered: