[WIP] Multithreading: separate diffing and DOM operations #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment asm-dom uses only one thread, the main one, to perform its work.
This is an experimental PR that aims to improve the performance by dividing the diffing algorithm and the DOM operations in two different threads. This is now possible thanks to the support of WebAssembly threads in Chrome 70, previously disabled due to a set of reasons involving spectre and meltdown. So, we can now use pthreads and emscripten.
We should firstly change our
Makefile
to setup the new compilation, improve the test suite and runs it directly in the browser, since we cannot mockWorker
andSharedArrayBuffer
in node.After that we can develop the new core part and benchmark it to see if it is better than the existing one.
Here is a list of things that needs to be done:
Makefile