Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HVSXROAD] Crossroads of the Elements - Sysop access to all users #249

Closed
brianmiller opened this issue Nov 2, 2020 · 2 comments · Fixed by #250
Closed

[HVSXROAD] Crossroads of the Elements - Sysop access to all users #249

brianmiller opened this issue Nov 2, 2020 · 2 comments · Fixed by #250
Assignees
Labels
enhancement New feature or request

Comments

@brianmiller
Copy link

Module Information

  • Identifier [HVSXROAD]
  • Module Name [Crossroads of the Elements]
  • Version [1.00j]

Describe the bug
All users have sysop level access in the game "sys" commands. E.g., SYS GOTO, SYS UPDATE, SYS BECOME, etc...

To Reproduce
Steps to reproduce the behavior:

  1. Create new user account
  2. Load Crossroads
  3. Issue the "sys" command

Expected behavior
Only users with "sysop" keys or role should have the ability to run sysop commands.

Screenshots
N/A

Software Information:

  • OS: [Fedora 32 and CentOS 8]
  • Telnet Client [Linux telnet, Telix under DOSBox]
@enusbaum enusbaum self-assigned this Nov 2, 2020
@enusbaum enusbaum added the enhancement New feature or request label Nov 2, 2020
@enusbaum
Copy link
Member

enusbaum commented Nov 2, 2020

Currently both haskey() and hasmkey() Ordinals return true for every key, regardless if the user has it.

I'm working on a Branch right now which sets default keys for new users and properly evaluates the keys assigned to a user.

PR pending.

@brianmiller
Copy link
Author

brianmiller commented Nov 3, 2020

Excellent. As soon as this is implemented, I'm ready to replace by BBS. :)

BTW: incredible work!

I'm happy to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants