Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Key Support #250

Merged
merged 8 commits into from
Nov 6, 2020
Merged

Account Key Support #250

merged 8 commits into from
Nov 6, 2020

Conversation

enusbaum
Copy link
Member

@enusbaum enusbaum commented Nov 3, 2020

  • Adds verification of Account Keys via haskey() and haskeym()
  • Default Keys DEMO and NORMAL assigned to new users, configurable via appsettings.json
  • RLOGIN users are given Default Keys
  • Database Reset assigns GUEST account Default Keys

Fixes #249

Copy link
Collaborator

@paladine paladine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests plz

- Impement haskey test
- Add `Reset()` methods to Accounts and AccounKeys Repositories
- Add Database Resets to ExportedModuleTestBase
@enusbaum enusbaum merged commit 9b7fc6c into master Nov 6, 2020
@brianmiller
Copy link

Is there a repository of test builds with these changes? I'm happy to test as well.

I signed up for monthly Patreon support and noticed mentions of test builds, but they looked older than the public releases.

Thanks, again!

@enusbaum
Copy link
Member Author

enusbaum commented Nov 6, 2020

@brianmiller You're able to download the automated builds here:

https://www.mbbsemu.com/Downloads

They are kicked off any time there's a commit/merge into master. Obviously more experimental than regular releases 😉

Also thank you for joining the Patreon and directly supporting the project! ❤️

@brianmiller
Copy link

FWIW, I have #110620-18 running and seems to be working great. As far as I've tested, only 'sysop' has sysop access in Crossroads, normal users do not, perfect.

Unfortunately, this version of MBBSEmu was crashing every time when just simply replacing the MBBSEmu exec, if I left BBSGEN.DB and BBSUSR.DB in place. The Crossroads database also had to be deleted.

I admit I didn't debug this much but we will likely need to ensure a clean upgrade--or at very least a way to backup the user/password database as well as the game databases.

It's looking good!

@tuday2
Copy link
Collaborator

tuday2 commented Nov 7, 2020

Apologies yes the change that went in to address that involved some major database schema changes and unfortunately there was no way around it. We are discussing a better way to flag when there is a schema change -- the change to sqlite has been a huge step forward and also having the correct account keys but it also came with having to erase databases.

Thanks again for testing and feel free to reach out if you have any other issues.

@enusbaum enusbaum deleted the keys branch November 7, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HVSXROAD] Crossroads of the Elements - Sysop access to all users
4 participants