Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New x87/x86 Opcodes #165

Merged
merged 5 commits into from
Oct 7, 2020
Merged

New x87/x86 Opcodes #165

merged 5 commits into from
Oct 7, 2020

Conversation

enusbaum
Copy link
Member

@enusbaum enusbaum commented Oct 5, 2020

  • Added FCLEX
  • Added FRNDINT
  • Added ROR
  • Added FTST
  • Added Support for "Loading" 80-Bit Floats (they're saved from the FPU as 64-bit, so we load 80-bit as 64-bit)
  • Added INT 32h and HLT as NOP commands

Fixes #157

- Added FCLEX, FNCLEX, FRNDINT, ROR, FTST
- Added HLT (nop)
- Added INT 3Eh (Ignore)
- Unit Tests for new FPU instructions and Rotate Right
@enusbaum enusbaum requested a review from paladine October 5, 2020 23:37
public class FCLEX_Tests : CpuTestBase
{
[Fact]
public void FCLEX_Test()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about a dup for fnclex too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCLEX and FNXCLEX are functionally the same. FCLEX just has an FPU WAIT (9B) before the FNCLEX, also why there's two ticks below.

Screen Shot 2020-10-06 at 11 07 53 AM

CreateCodeSegment(instructions);

mbbsEmuCpuCore.Tick();
mbbsEmuCpuCore.Tick();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two ticks?

MBBSEmu.Tests/CPU/FRNDINT_Tests.cs Show resolved Hide resolved
MBBSEmu.Tests/CPU/FTST_Tests.cs Show resolved Hide resolved
"Identifier": "ELWCHT",
"Path": "D:\\BBS\\Mbbsemu\\modules\\elwchtd\\",
"MenuOptionKey": "C"
"Identifier": "ELWSAFE",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be part of the repo?

@enusbaum enusbaum requested a review from paladine October 6, 2020 15:28
@enusbaum enusbaum merged commit 3c8b751 into master Oct 7, 2020
@enusbaum enusbaum deleted the x87-opcodes branch October 7, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ELWGOLF] Electronic Fairways - Module crashes during gameplay, swinging club
2 participants