Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Btrieve ACS #298

Merged
merged 14 commits into from
Nov 19, 2020
Merged

Implement Btrieve ACS #298

merged 14 commits into from
Nov 19, 2020

Conversation

paladine
Copy link
Collaborator

  • Implements Btrieve ACS functionality + adds relevant tests
  • Adds a version number to the Btrieve database for schema compatibility
  • Speeds up unit tests by using a shared in memory account db for unit tests (not just integration)
  • Handles database Stream reads to make sure we read the entire Stream

@paladine
Copy link
Collaborator Author

  • Also added a Seek cursor direction for KeyEqual queries, instead of using that hack >= query + manual key validation. Manual key validation would have been more difficult given ACS. Makes sense to just let sqlite do it

@tuday2 tuday2 linked an issue Nov 17, 2020 that may be closed by this pull request
Copy link
Member

@enusbaum enusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting changes

MBBSEmu.Tests/Btrieve/BtrieveFileProcessor_Tests.cs Outdated Show resolved Hide resolved
MBBSEmu.Tests/Btrieve/BtrieveKey_Tests.cs Outdated Show resolved Hide resolved
MBBSEmu.Tests/Btrieve/BtrieveKey_Tests.cs Outdated Show resolved Hide resolved
MBBSEmu.Tests/Btrieve/BtrieveKey_Tests.cs Outdated Show resolved Hide resolved
MBBSEmu.Tests/Btrieve/BtrieveKey_Tests.cs Outdated Show resolved Hide resolved
MBBSEmu/Btrieve/BtrieveKey.cs Outdated Show resolved Hide resolved
MBBSEmu/Btrieve/BtrieveKey.cs Outdated Show resolved Hide resolved
MBBSEmu/Btrieve/BtrieveUtil.cs Outdated Show resolved Hide resolved
MBBSEmu/Btrieve/BtrieveUtil.cs Outdated Show resolved Hide resolved
@paladine paladine merged commit 72fc9d3 into master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Btrieve ACS
2 participants