Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra chars in buffer from leaking into module #311

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

tuday2
Copy link
Collaborator

@tuday2 tuday2 commented Nov 26, 2020

*Set InputBuffer length to 1 before entering module
*Fixes extra characters from being sent to module (when menu items >9 or menuoption key that is 2 chars)
*Modules behave strangely when setting to 0

*Set InputBuffer length to 1 before entering module
*Fixes extra characters from being sent to module (when menu items >9 or menuoption key that is 2 chars)
*Modules behave strangely when setting to 0
@tuday2 tuday2 requested a review from enusbaum November 26, 2020 21:17
@tuday2
Copy link
Collaborator Author

tuday2 commented Nov 27, 2020

@enusbaum Changed approach -- restricted menu item to 1 character

moved logic from majorbbs.cs to initial module load to avoid duplicating existing module MenuOptionKeys with auto generated ones

@enusbaum enusbaum merged commit 7719b4d into mbbsemu:master Dec 2, 2020
@tuday2 tuday2 deleted the 2digit-menu-item-fix branch December 2, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants